[PATCH] D53408: [PPC64] Long branch thunks.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/ELF/ppc64-long-branch.s:8
+# RUN: llvm-objdump -d -start-address=0x10010000 -stop-address=0x10010018 %t | FileCheck %s -check-prefix=CALLEE_DUMP
+# RUN: llvm-objdump -d -start-address=0x12010020 -stop-address=0x12010084 %t | FileCheck %s -check-prefix=CALLER_DUMP
+# RUN: llvm-objdump -D -start-address=0x12020008 -stop-address=0x12020010 %t | FileCheck %s -check-prefix=BRANCH_LT_LE
----------------
This is a warning `ld.lld: warning: cannot find entry symbol _start; defaulting to 0x10010000`

If it is obvious that `_start` serves as a caller, you may rename `caller` to `_start`, or use `lld -e caller` to silent the warning.


================
Comment at: test/ELF/ppc64-long-branch.s:12
+
+# RUN llvm-mc -filetype=obj -triple=powerpc64-unknown-linux %s -o %t.o
+# RUN llvm-mc -filetype=obj -triple=powerpc64-unknown-linux %p/Inputs/ppc64-func-global-entry.s -o %t2.o
----------------
These big-endian RUN lines should use `RUN:`. `RUN ` will not run any tests :)




Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53408