[PATCH] D53356: [InstCombine] Teach the move free before null test opti how to deal with noop casts

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 15:39:15 PDT 2018


spatel added a comment.

This is adding to a transform that seems out-of-place for instcombine:

1. It's a hoist transform that relies on SimplifyCFG to do the real optimization. Does the whole thing belong there (or CGP) instead?
2. It's the only transform in instcombine that is gated by 'minsize', so it's a limited optimization rather than a canonicalization?


Repository:
  rL LLVM

https://reviews.llvm.org/D53356





More information about the llvm-commits mailing list