[PATCH] D52227: LLVM: Expose SimplifyCFGPass (as used in PassBuilder::buildModuleOptimizationPipeline) in PassRegistry.def

[Sanjay Patel via Phabricator via llvm-commits]

spatel added reviewers: craig.topper, davide, hfinkel.
spatel added a comment.

In https://reviews.llvm.org/D52227#1272506, @georgevdd wrote:

> Is there anything I need to do to help this along? It's over a month old, now.


Feel free to ping weekly to push this faster. I lost track of the patch.

The backstory for those pass options is that we actually had a named pass ("latesimplifycfg") encapsulating them before we decided we wanted the flexibility to be able to turn things on/off with finer granularity:
https://reviews.llvm.org/D38631

...so this patch is proposing to partially restore that (it doesn't change anything for the default pass manager?).

It's going to effectively make the bundle of options shown here a standard config by giving that bundle a name.

There was a suggestion to break SimplifyCFG into multiple passes rather than providing a pile of options here:
https://reviews.llvm.org/D38566

That would be ideal because it would give us both the flexibility and the test-ability that this patch is seeking?
I don't know how much work that would be, so I'm not sure if it's fair to ask for that change. 
If we decide that this patch isn't the wrong direction, it will need tests to verify the new functionality.


Repository:
  rL LLVM

https://reviews.llvm.org/D52227