[PATCH] D53538: NFC: Reorganize the demangler a bit

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 13:14:47 PDT 2018


erik.pilkington updated this revision to Diff 170738.
erik.pilkington added a comment.

> 1. Should we document in the README.txt that we want to split "demangle" out to a separate top-level directory some time after the monorepo move?

Sure, new patch adds this.

> 2. I suggest adding a bot that runs the script and confirms that git status is clean.

That's a good idea. I don't know how to go about doing that, but it seems like it should be pretty straightforward.


https://reviews.llvm.org/D53538

Files:
  libcxxabi/src/cxa_demangle.cpp
  libcxxabi/src/demangle/Compiler.h
  libcxxabi/src/demangle/DemangleConfig.h
  libcxxabi/src/demangle/ItaniumDemangle.h
  libcxxabi/src/demangle/README.txt
  libcxxabi/src/demangle/StringView.h
  libcxxabi/src/demangle/Utility.h
  libcxxabi/src/demangle/cp-to-llvm.sh
  llvm/include/llvm/Demangle/Compiler.h
  llvm/include/llvm/Demangle/DemangleConfig.h
  llvm/include/llvm/Demangle/ItaniumDemangle.h
  llvm/include/llvm/Demangle/README.txt
  llvm/include/llvm/Demangle/StringView.h
  llvm/include/llvm/Demangle/Utility.h
  llvm/lib/Demangle/MicrosoftDemangle.cpp
  llvm/lib/Demangle/MicrosoftDemangleNodes.cpp
  llvm/lib/Demangle/MicrosoftDemangleNodes.h
  llvm/lib/Support/ItaniumManglingCanonicalizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53538.170738.patch
Type: text/x-patch
Size: 28735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181023/0bf18ed2/attachment.bin>


More information about the llvm-commits mailing list