[PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added inline comments.


================
Comment at: llvm-objcopy.cpp:665
     } else {
       FileBuffer FB(Config.OutputFilename);
+      executeObjcopyOnBinary(Config, *BinaryOrErr.get().getBinary(), FB);
----------------
alexshap wrote:
> jakehehrlich wrote:
> > to mirror executeObjcopyOnArchive, can we move the construction of the file buffer into executeObjcopyOnBinary.
> the thing is that executeObjcopyOnBinary is called inside executeObjcopyOnArchive with a different type of buffer
Right, I should have known better. That was my goof. Carry on.


Repository:
  rL LLVM

https://reviews.llvm.org/D53311