[PATCH] D53446: Set MAttrs in LTO mode

Yin Ma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 11:46:34 PDT 2018


yinma added inline comments.


================
Comment at: Common/TargetOptionsCommandFlags.cpp:36
+
+std::vector<std::string> lld::GetMAttrs(){
+  std::vector<std::string> Attrs;
----------------
MaskRay wrote:
> `return std::vector<std::string>(MAttrs.begin(), MAttrs.end());`
OK


================
Comment at: Common/TargetOptionsCommandFlags.cpp:38
+  std::vector<std::string> Attrs;
+  for (std::string &Attr : MAttrs)
+    Attrs.push_back(Attr);
----------------
ruiu wrote:
> Where is this `MAttrs` defined?
Those can be set by commend line options


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53446





More information about the llvm-commits mailing list