[PATCH] D53564: [llvm-dwarfdump] - Fix incorrect parsing of the DW_LLE_startx_length

[Adrian Prantl via Phabricator via llvm-commits]

aprantl requested changes to this revision.
aprantl added a comment.
This revision now requires changes to proceed.

In https://reviews.llvm.org/D53564#1272837, @dblaikie wrote:

> In https://reviews.llvm.org/D53564#1272791, @aprantl wrote:
>
> > In https://reviews.llvm.org/D53564#1272771, @dblaikie wrote:
> >
> > > So it should change based on DWARF version, unfortunately.
> >
> >
> > What happens when the llvm-dwarfdump with this patch reads the old format? Depending on the answer it might be useful to also add a --verify check for this. I'll leave this up to you.
>
>
> That's what I mean by "should change based on DWARF version" - this patch, as-is, is insufficient (since it'd break parsing pre-standard split-DWARF).


Agreed.

> Not sure what --verify could do about this - since the data isn't self-describing, bytes are bytes and these rules specify how to interpret those bytes. If that makes sense?

You're right. This is an abbrev entry; just raw data.


https://reviews.llvm.org/D53564