[PATCH] D53519: [CodeGen] skip lifetime end marker in isInTailCallPosition

[Robert Lougher via Phabricator via llvm-commits]

rob.lougher added a comment.

In https://reviews.llvm.org/D53519#1272775, @rnk wrote:

> Is there some more general property for us to check that this intrinsic shares with other annotation-like intrinsics like llvm.assume?


Good point. I couldn't find anything when I looked. Skipping of intrinsics seems to be done in an ad-hoc way throughout the code. Checks for debug intrinsics are common. The stack protector initially just skipped debug intrinsics - lifetime markers were added recently in https://reviews.llvm.org/D45331. The loop vectorizer checks for assume, lifetime_end, lifetime_start and sideeffect.

I only checked for lifetime_end because this is the only one which is likely to appear between a valid tail call and the ret. However, I can add assume, start and sideeffect? Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D53519