[PATCH] D53534: [hot-cold-split] Name split functions with ".cold" suffix

[Sebastian Pop via Phabricator via llvm-commits]

sebpop added inline comments.


================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:678
+      Suffix.empty() ? oldFunction->getName() + "_" + header->getName()
+                     : oldFunction->getName() + Suffix,
+      M);
----------------
tejohnson wrote:
> sebpop wrote:
> > In the case of more than one region extracted from a function, this code may create functions with identical names which would create link problems.
> > 
> Will the hot cold split pass extract more than one cold function from a single function?
Yes with https://reviews.llvm.org/D53588


Repository:
  rL LLVM

https://reviews.llvm.org/D53534