[PATCH] D53066: [RFC] [Driver] Use forward slashes in most linker arguments

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 01:51:53 PDT 2018


mstorsjo reopened this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

So, this failed due to some tests expecting to find the exact same path substring in different parts of the output (used with FileCheck captured variables): http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/763

What's the best course of action here - trying to extend the changes to forward slashes in more places, to make these tests pass, or adjust the tests to not break due to this? Or extend FileCheck to allow checks for "similar text, modulo path separator differences"? :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D53066





More information about the llvm-commits mailing list