[PATCH] D53227: [hwasan] add stack frame descriptions.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:742
+  // Put GV into the F's Comadat so that if F is deleted GV can be deleted too.
+  if (!F.getName().startswith("hwasan"))
+    if (auto Comdat = GetOrCreateFunctionComdat(F, CurModuleUniqueId))
----------------
eugenis wrote:
> kcc wrote:
> > eugenis wrote:
> > > Why would F's name start with "hwasan"? Did you mean "__hwasan"?
> > No, this one is for the CTOR (HwasanCtorFunction above)
> Why not compare F with HwasanCtorFunction?
Yep, done. 


Repository:
  rL LLVM

https://reviews.llvm.org/D53227