[PATCH] D53534: [hot-cold-split] Name split functions with ".cold" suffix

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 22 15:50:06 PDT 2018


tejohnson created this revision.
tejohnson added reviewers: sebpop, hiraditya.
Herald added a subscriber: erik.pilkington.

The current default of appending "_"+entry block label to the new
extracted cold function breaks demangling. Change this to ".cold" for hot
cold splitting (other uses of CodeExtractor still use old naming), since
the demangler knows how to handle suffixes starting with ".". This
is also consistent with how gcc names the split cold functions.


Repository:
  rL LLVM

https://reviews.llvm.org/D53534

Files:
  include/llvm/Transforms/Utils/CodeExtractor.h
  lib/Transforms/IPO/HotColdSplitting.cpp
  lib/Transforms/Utils/CodeExtractor.cpp
  test/Transforms/HotColdSplit/split-cold-2.ll
  test/Transforms/HotColdSplit/split-out-dbg-val-of-arg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53534.170518.patch
Type: text/x-patch
Size: 5536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181022/18db9dc2/attachment.bin>


More information about the llvm-commits mailing list