[PATCH] D52999: [FileCheck] Annotate input dump

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D52999#1271022, @george.karpenkov wrote:

> @jdenny
>
> > I'm willing to split up the patch more if it helps the review
>
> Yes please, to be honest I can't still fully understand the feature description, let alone the code.
>  I have asked my colleague to take a glance, and his verdict was the same, so I'm not alone there.
>
> You have a lot of new features in your FileCheck output; could you think of a way to separate them into simple, small, understandable chunks?


OK, but please work with me to plan a way to break up the series that would actually prove helpful to you.  Here are two proposals:

1. Here's the plan I proposed in an earlier comment, but I've updated it for recent changes:
  1. Make changes to include/llvm/Support/FileCheck.h and lib/Support/FileCheck.cpp, which gather the list of diagnostics.
  2. Make changes to utils/FileCheck/FileCheck.cpp, which converts the list of diagnostics to annotations on the input.  Include test and doc changes in this patch because this is where they become effective.

    Because you see FileCheck's *output* as many new features, I'm afraid all the parts you find confusing would all appear in the second patch, so I'm not sure this plan would prove helpful to you.

2. This patch introduces input annotations for existing diagnostics.  Those diagnostics are enumerated in MatchType in FileCheckDiag in llvm/include/llvm/Support/FileCheck.h.  Would it be helpful to have each patch introduce annotations for one MatchType member?  The first patch would likely be the largest as it would introduce boilerplate.

Please let me know which of these proposals you prefer, or propose something else.

Thanks for your help.


https://reviews.llvm.org/D52999