[PATCH] D53495: Add OUTPUT_FORMAT linker script directive support.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/ScriptParser.cpp:410
+  if (Config->EKind == ELFNoneKind)
+    std::tie(Config->EKind, Config->EMachine) = BfdName;
+
----------------
ruiu wrote:
> grimar wrote:
> > So I think this means LLD will error out when seeing the object file with incompatible architecture after parsing the script containing `OUTPUT_FORMAT`. Behavior is fine, but I think there is no test provided for that case?
> I don't think we need that test case.
Then you should be able to simplify to

`std::tie(Config->EKind, Config->EMachine) = readBfdName();`


https://reviews.llvm.org/D53495