[PATCH] D53424: Enable thread specific cl::opt values for multi-threaded support

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Haven't looked too much at the implementation details yet, but I definitely like the idea.



================
Comment at: include/llvm/Support/CommandLine.h:1184
+struct Destructible {
+  virtual ~Destructible() = default;
+};
----------------
This should be declared explicitly in a .cpp file to provide an "anchor" for the vtable. (Otherwise the destructor and the vtable etc. are emitted in every compilation unit that includes this file, which is a waste of compile time.)


Repository:
  rL LLVM

https://reviews.llvm.org/D53424