[PATCH] D53452: [ARM] Allow TBB formation for Thumb1 in more cases.

[Eli Friedman via Phabricator via llvm-commits]

efriedma created this revision.
efriedma added reviewers: SjoerdMeijer, t.p.northover, dmgreen.
Herald added subscribers: arphaman, chrib, kristof.beyls, javed.absar.

Requiring the input of the first shift to be killed is more conservative than necessary; we can just insert an explicit copy instead.

Thinking about it a bit more, I'm not sure it's really worth complicating this code to catch a few more cases; it's not uncommon (I found 7 instances in a relatively small codebase), but it's not really common either.  That said, I have another patch that breaks a couple regression tests without this fix.


Repository:
  rL LLVM

https://reviews.llvm.org/D53452

Files:
  lib/Target/ARM/ARMConstantIslandPass.cpp
  test/CodeGen/Thumb/tbb-live-index.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53452.170245.patch
Type: text/x-patch
Size: 10938 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181019/e6880b54/attachment.bin>