[PATCH] D53440: [LoopUnroll] allow customization for new-pass-manager version of LoopUnroll

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: include/llvm/Transforms/Scalar/LoopUnrollPass.h:49
 
+  /// Selector for the optional behavior - Partial unrolling.
+  /// Call with \p Partial being true to enable, false to disable.
----------------
tejohnson wrote:
> I think the usual mechanism for the new PM is to pass options to the pass constructor. E.g. see InlinerPass.
I really dislike passing a bunch of booleans and then adding comments to name them, like all the callers of tryToUnrollLoop are doing. :(


Repository:
  rL LLVM

https://reviews.llvm.org/D53440