[PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 19 12:48:16 PDT 2018


alexshap added a comment.

okay, i thought that this way it was clearer, but alternatively I can do only the code changes / refactoring in this diff, and move things into a separate file in the next diff. Does it sound good, @jhenderson  ?



================
Comment at: ELFObjcopy.cpp:453
+      auto File = SecPair.second;
+      auto BufOrErr = ::llvm::MemoryBuffer::getFile(File);
+      if (!BufOrErr)
----------------
jhenderson wrote:
> What's the reason for the extra namespacing here? It wasn't there before.
i think it's a left-over of some debugging, I will clean it up, thanks


Repository:
  rL LLVM

https://reviews.llvm.org/D53311





More information about the llvm-commits mailing list