[PATCH] D52162: [XRay] Support for Fuchsia

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_tsc.h:32
+
+uint64_t getTSCFrequency();
+
----------------
Why not make this an inline like the clock_gettime case below does?


================
Comment at: compiler-rt/lib/xray/xray_tsc.h:34
+
+bool probeRequiredCPUFeatures();
+
----------------
Likewise.


================
Comment at: compiler-rt/lib/xray/xray_utils.cc:119
+
+  // Use the dumpfile symbolizer markup element to write the name of VMO.
+  Report("XRay: " FORMAT_DUMPFILE "\n", ProfileSinkName, VmoName);
----------------
s/of/of the/


================
Comment at: compiler-rt/lib/xray/xray_x86_64.cc:334
 // need. In x86_64 this will be rdtscp support.
 bool probeRequiredCPUFeatures() XRAY_NEVER_INSTRUMENT {
   unsigned int EAX, EBX, ECX, EDX;
----------------
This code is wrong for Fuchsia.  There's nothing to do here but return true.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52162