[PATCH] D53437: Schedule Hot Cold Splitting pass after most optimization passes

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya created this revision.
hiraditya added reviewers: sebpop, vsk.

In the new-pass manager, hot cold splitting was schedule too early.


https://reviews.llvm.org/D53437

Files:
  lib/Passes/PassBuilder.cpp


Index: lib/Passes/PassBuilder.cpp
===================================================================
--- lib/Passes/PassBuilder.cpp
+++ lib/Passes/PassBuilder.cpp
@@ -621,9 +621,6 @@
                                            true));
   }
 
-  if (EnableHotColdSplit)
-    MPM.addPass(HotColdSplittingPass());
-
   // Interprocedural constant propagation now that basic cleanup has occurred
   // and prior to optimizing globals.
   // FIXME: This position in the pipeline hasn't been carefully considered in
@@ -713,6 +710,9 @@
   MainCGPipeline.addPass(createCGSCCToFunctionPassAdaptor(
       buildFunctionSimplificationPipeline(Level, Phase, DebugLogging)));
 
+  if (EnableHotColdSplit)
+    MPM.addPass(HotColdSplittingPass());
+
   for (auto &C : CGSCCOptimizerLateEPCallbacks)
     C(MainCGPipeline, Level);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53437.170199.patch
Type: text/x-patch
Size: 820 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181019/6aa17beb/attachment.bin>