[PATCH] D53423: [llvm-exegesis] X87 RFP setup code.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-exegesis/lib/X86/Target.cpp:186
+  std::vector<llvm::MCInst> loadX87STAndFinalize(unsigned Reg) {
+    initStack(kX87Bytes);
+    add(llvm::MCInstBuilder(llvm::X86::LD_F80m)
----------------
`kF80Bytes` so it makes more sense to use `LD_F80m` afterwards


================
Comment at: unittests/tools/llvm-exegesis/X86/TargetTest.cpp:299
 
 TEST_F(Core2TargetTest, SetRegToST0_32Bits) {
   EXPECT_THAT(
----------------
Can you add a comment for all non-80bits tests to explain why we put an 80bits value on the stack?


Repository:
  rL LLVM

https://reviews.llvm.org/D53423