[PATCH] D53393: Add a addAbsolute static function to Writer.cpp

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 19 02:40:00 PDT 2018


arichardson added a comment.

Thank you very much for the detailed explanation.

I am totally fine with future breakage if you don't mind me committing this.
In addition to fixing our out-of-tree target, this patch really helps my understanding of the function because there is another lambda named `Add` a few lines down that adds a symbol that might point at the elf header instead of being an absolute symbol. If you'd rather keep it as a local lambda instead of a static function just before, I could also rename it to `AddAbsolute`


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53393





More information about the llvm-commits mailing list