[PATCH] D53135: Remove top-level using declaration from header files, as these aliases leak.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: cfe/trunk/include/clang/Serialization/GlobalModuleIndex.h:147
   static std::pair<GlobalModuleIndex *, ErrorCode>
-  readIndex(StringRef Path);
+  readIndex(llvm::StringRef Path);
 
----------------
It's preferred to include clang/Basic/LLVM.h instead and use the StringRef in the clang namespace:
https://github.com/llvm-mirror/clang/blob/master/include/clang/Basic/LLVM.h

Otherwise we'd have llvm::StringRef literally everywhere.


Repository:
  rL LLVM

https://reviews.llvm.org/D53135