[PATCH] D52968: [TI removal] Update the C API for the move away from `TerminatorInst`.

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 18 15:32:32 PDT 2018


jyknight added inline comments.


================
Comment at: llvm/include/llvm-c/Core.h:2959
+ */
+LLVMBool LLVMIsTerminator(LLVMValueRef Inst);
+
----------------
I would actually make this function "LLVMIsATerminatorInst", *replacing* the LLVMIsATermiantorInst function defined using "macro" at the top. (A similar thing was done with e.g. LLVMIsAMDNode). With that, I think this change will be 100% compatible in the C API.


================
Comment at: llvm/include/llvm-c/Core.h:3101
  *
- * Functions in this group only apply to instructions that map to
- * llvm::TerminatorInst instances.
+ * Functions in this group only apply to instructions for which LLVMIsTerminator
+ * returns true.
----------------
(LLVMIsATerminator)


Repository:
  rL LLVM

https://reviews.llvm.org/D52968





More information about the llvm-commits mailing list