[PATCH] D53240: [WebAssembly] WebAssemblyLowerEmscriptenEHSjLj: use getter/setter for accessing tempRet0

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 17 18:09:49 PDT 2018


aheejin added a comment.

> The alternative you are suggesting is to create several sets of global+getter+setter right? getReturnHighBits/setReturnHighBits/__returnHighBit + getLongJmpArg/setLongJmpArg/__longJmpArg ... etc.

Not really. What I was suggesting was use different names for EH's `__tempRet0` and `other.test_sixtyfour_bit_return_value`'s `__tempRet0` and do nothing. In other words what I meant was we might not need to impose a strict getter/setter rules for every variable, because we don't know how many we will end up with. Person who creates a new variable can add getter or setter if it is necessary, but I was not sure if we want to impose a strict rule that all of getter and setter for cross-communicating variables should be generated from binaryen's legalize-js-interface.


Repository:
  rL LLVM

https://reviews.llvm.org/D53240





More information about the llvm-commits mailing list