[PATCH] D53362: [Prototype] Heap-To-Stack Conversion Pass

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 17 11:42:53 PDT 2018


xbolva00 added a subscriber: efriedma.
xbolva00 added a comment.

In https://reviews.llvm.org/D53362#1267885, @hfinkel wrote:

> Add the pointer-capturing check when potential exits are found.


Not sure if enough, since @efriedma noted in https://reviews.llvm.org/D47345:

"Your "capture" function captures the pointer, but it's possible to write a function which takes the pointer as a parameter but doesn't capture it. For example, given the function void f(void *p) { free(p); }, LLVM will mark the parameter "p" nocapture."


https://reviews.llvm.org/D53362





More information about the llvm-commits mailing list