[PATCH] D51695: [MC] [AsmParser]: Ensure a new CFI frame is not opened within an existing one when using cc1as (causing a crash due to failed assert).

Tue Oct 16 18:23:33 PDT 2018

kristina updated this revision to Diff 169934.
kristina added 1 blocking reviewer(s): rnk.
kristina added a comment.

Address comments by @rnk and redo this on MCStreamer level adding SMLoc information to the diagnostic as a bonus. Room for followup patches to propagate more source locations for other directives but for now this is out of scope of this patch as it deals with the assembler crash.

Repository:
  rL LLVM

https://reviews.llvm.org/D51695

Files:
  include/llvm/MC/MCStreamer.h
  lib/MC/MCParser/AsmParser.cpp
  lib/MC/MCStreamer.cpp
  test/MC/X86/cfi-open-within-another-crash.s
  test/MC/X86/cfi-scope-errors.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51695.169934.patch
Type: text/x-patch
Size: 4003 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181017/a7de624b/attachment.bin>