[PATCH] D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 16 16:07:02 PDT 2018


tejohnson created this revision.
tejohnson added a reviewer: davidxl.
Herald added subscribers: arphaman, dexonsmith, steven_wu, eraman, inglorion, mehdi_amini.

The NotEligibleToImport flag on the GlobalValueSummary was set if it
isn't legal to import (e.g. because it references unpromotable locals)
and when it can't be inlined (in which case importing is pointless).

I split out the inlinable piece into a separate flag on the
FunctionSummary (doesn't make sense for aliases or global variables),
because in the future we may want to import for reasons other than
inlining.


Repository:
  rL LLVM

https://reviews.llvm.org/D53345

Files:
  include/llvm/IR/ModuleSummaryIndex.h
  include/llvm/Transforms/IPO/FunctionImport.h
  lib/Analysis/ModuleSummaryAnalysis.cpp
  lib/AsmParser/LLLexer.cpp
  lib/AsmParser/LLParser.cpp
  lib/AsmParser/LLToken.h
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/ModuleSummaryIndex.cpp
  lib/Transforms/IPO/FunctionImport.cpp
  test/Assembler/thinlto-summary.ll
  test/Bitcode/thinlto-function-summary.ll
  test/ThinLTO/X86/dot-dumper.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53345.169906.patch
Type: text/x-patch
Size: 12575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181016/9c5129e1/attachment-0001.bin>


More information about the llvm-commits mailing list