[PATCH] D53245: Teach the DominatorTree fallback to recalculation when applying updates to speedup JT (PR37929)

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 16 08:34:50 PDT 2018


kuhar added a comment.

In https://reviews.llvm.org/D53245#1266421, @NutshellySima wrote:

> @kuhar , here is the statistics for `k*α>n`:


Awesome, thanks for the numbers. It's much easier to reason about it this way. But I'm a bit confused by why you measured it like this. Can we have statistics with respect to nodes visited during DFS? That should be highly correlated and give us more confidence in the measured times.

> I think maybe "40" is a better choice?

30 seems best to me :)


https://reviews.llvm.org/D53245





More information about the llvm-commits mailing list