[PATCH] D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:2532
 
+void llvm::hoistAllInstructionsInto(BasicBlock *DomBlock,Instruction *InsertPt,
+                                    BasicBlock *BB) {
----------------
aprantl wrote:
> clang-format please
Done.


================
Comment at: lib/Transforms/Utils/Local.cpp:2549
+  // encode predicated DIExpressions that yield different results on different
+  // code paths.
+  for (BasicBlock::iterator II = BB->begin(), IE = BB->end(); II != IE; ) {
----------------
aprantl wrote:
> As I explained in https://bugs.llvm.org/show_bug.cgi?id=39141#c8 the more fundamental reason why the dbg.values need to be deleted is because there won't be any instructions with a DILocation in either branch left after performing the transformation. We can only insert a dbg.value after the two branches are joined again.
I have included your comments for a better understanding of 'hoistAllInstructionsInto'.


https://reviews.llvm.org/D53287