[PATCH] D53142: [VPlan] Script to extract VPlan digraphs from log

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 15 16:30:21 PDT 2018


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: utils/extract_vplan.py:34
+        p = subprocess.Popen([dot, '-Tpng', '-o', filename], encoding='utf-8',
+                              stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+        out, err = p.communicate(input=vplan)
----------------
nit: line quite long


https://reviews.llvm.org/D53142





More information about the llvm-commits mailing list