[PATCH] D52904: [hot-cold-split] fix static analysis of cold regions

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

In https://reviews.llvm.org/D52904#1265895, @sebpop wrote:

> In https://reviews.llvm.org/D52904#1265893, @hiraditya wrote:
>
> > > With this patch I now see a 3% speedup on sqlite vs. no hot-cold-split pass.
> >
> > Awesome! Thanks for improving this!
>
>
> I think the 3% uplift in performance is within the noise level.
>  At least with this patch I do not see the 10% regression in performance with hot/cold partitioning
>  which most likely was due to doubling the cost of function calls when the whole function was outlined.


I think hot-cold splitting with function merging can help reduce code-size as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D52904