[PATCH] D53294: [ThinLTO] Add an option to disable (thin)lto internalization.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 15 13:38:46 PDT 2018


tejohnson added a comment.

Code looks fine now but just realized there is no test. You can probably create one test with a function that can normally be internalized, and then try it for the 4 combinations of LTO/ThinLTO and new/old LTO with and without your option. See test/ThinLTO/X86/internalize.ll for a ThinLTO-specific internalization test that tests both the old (via llvm-lto) and the new (via llvm-lto2) LTO APIs.


Repository:
  rL LLVM

https://reviews.llvm.org/D53294





More information about the llvm-commits mailing list