[PATCH] D53163: [llvm-strip] Support -s alias for --strip-all. Make both strip and objcopy case sensitive to support both -s (--strip-all) and -S (--strip-debug).

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

LGTM with the inline comment fixed.

I agree that command-line flags shouldn't be case-sensitive in general. I would expect e.g. -k and -K to be two different switches, and if one did not exist, then I'd expect an error.



================
Comment at: test/tools/llvm-objcopy/strip-all.test:42-44
+# RUN: cp %t %t10
+# RUN: llvm-objcopy -S %t10 %t10
+# RUN: cmp %t2 %t10
----------------
Nit: To reduce unnecessary changes in the diffs could you keep this as %t9, and move the llvm-strip -s case to below it, please.


Repository:
  rL LLVM

https://reviews.llvm.org/D53163