[PATCH] D53279: [SelectionDAG] Support promotion of FRAMEADDR/RETURNADDR operands

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 15 10:27:40 PDT 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1327
+  // Promote the RETURNADDR/FRAMEADDR argument to a supported integer width.
+  SDValue Op = GetPromotedInteger(N->getOperand(0));
+  return SDValue(DAG.UpdateNodeOperands(N, Op), 0);
----------------
Not that it actually affects the generated code, but it would probably be more clear to use ZExtPromotedInteger.


https://reviews.llvm.org/D53279





More information about the llvm-commits mailing list