[PATCH] D53253: [Merge SImilar Function ThinLTO 4/n] Make merge function decisions before the thin-lto stage

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

It's hard to review the changes the way they are currently split up. E.g. This patch adds some fields to the index, without using them or testing them. Those changes are in a different patch or two. It would be good to isolate all the changes that create and set these new index fields and test them via dumping the index to assembly and looking for expected values. Then have another patch that uses them in the FunctionImporter. Etc.

Also, it looks like the changes are only enabled for:

- the old pass manager
- the old LTO API (lib/LTO/ThinLTOCodeGenerator.cpp).

Please also add to the new pass manager and the new LTO API (see LTO/LTO.cpp) at the same time.



================
Comment at: include/llvm/Transforms/IPO/WholeProgramDevirt.h:234
+/// Populates information from each function summary to module summary index.
+void computeMergeSimilarFunctions(ModuleSummaryIndex &Index);
+
----------------
This isn't the right file to declare this function, which is unrelated to WPD.


https://reviews.llvm.org/D53253