[PATCH] D53270: [NewPM] implement SCC printing for -print-before-all/-print-after-all

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev marked 2 inline comments as done.
fedor.sergeev added inline comments.


================
Comment at: lib/Passes/StandardInstrumentations.cpp:40
 void unwrapAndPrint(StringRef Banner, Any IR) {
-  if (any_isa<const CallGraphSCC *>(IR) ||
-      any_isa<const LazyCallGraph::SCC *>(IR))
----------------
skatkov wrote:
> what about CallGraphSCC?
> I seen an implementation for LazyCakkGraph but do not see for CallGraphSCC?
CallGraphSCC is a legacy thing for legacy CallGraphSCCPass.
Attempt to call unwrapAndPrint with anything other than new-pm IRUnits will lead to llvm-unreachable at the end of this function.


Repository:
  rL LLVM

https://reviews.llvm.org/D53270