[PATCH] D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 14 19:58:18 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/hexagon-eflag.s:4
+# RUN: llvm-mc -filetype=obj -mv60 -triple=hexagon-unknown-elf %S/Inputs/hexagon.s -o %t2
+# RUN: ld.lld %t2 %t  -o %t3
+# RUN: llvm-readelf -h  %t3 | FileCheck %s
----------------
Remove an extraneous space.


================
Comment at: test/ELF/hexagon-eflag.s:5
+# RUN: ld.lld %t2 %t  -o %t3
+# RUN: llvm-readelf -h  %t3 | FileCheck %s
+
----------------
Ditto


================
Comment at: test/ELF/hexagon-eflag.s:8
+# Verify that the largest arch in the input list is selected.
+# CHECK:  Flags:                             0x62
----------------
FileCheck doesn't distinguish 2 or more spaces from a single space, so please remove extraneous spaces between "Flags:" and 0x62.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53204





More information about the llvm-commits mailing list