[llvm] r344478 - [ORC] Remove XXLayer::add methods that default to using the main JITDylib.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 14 09:10:00 PDT 2018


Author: lhames
Date: Sun Oct 14 09:09:59 2018
New Revision: 344478

URL: http://llvm.org/viewvc/llvm-project?rev=344478&view=rev
Log:
[ORC] Remove XXLayer::add methods that default to using the main JITDylib.

They're not currently used and may complicate upcoming changes to add's
signature and behavior.

Modified:
    llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h

Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h?rev=344478&r1=344477&r2=344478&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h Sun Oct 14 09:09:59 2018
@@ -51,12 +51,6 @@ public:
   /// JITDylib.
   virtual Error add(JITDylib &JD, VModuleKey K, ThreadSafeModule TSM);
 
-  /// Adds a MaterializationUnit representing the given IR to the main
-  /// JITDylib.
-  Error add(VModuleKey K, ThreadSafeModule TSM) {
-    return add(ES.getMainJITDylib(), K, std::move(TSM));
-  }
-
   /// Emit should materialize the given IR.
   virtual void emit(MaterializationResponsibility R, VModuleKey K,
                     ThreadSafeModule TSM) = 0;
@@ -127,12 +121,6 @@ public:
   /// JITDylib.
   virtual Error add(JITDylib &JD, VModuleKey K, std::unique_ptr<MemoryBuffer> O);
 
-  /// Adds a MaterializationUnit representing the given object to the main
-  /// JITDylib.
-  Error add(VModuleKey K, std::unique_ptr<MemoryBuffer> O) {
-    return add(ES.getMainJITDylib(), K, std::move(O));
-  }
-
   /// Emit should materialize the given IR.
   virtual void emit(MaterializationResponsibility R, VModuleKey K,
                     std::unique_ptr<MemoryBuffer> O) = 0;




More information about the llvm-commits mailing list