[PATCH] D52845: Update entry count for cold calls

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 13 21:42:50 PDT 2018


wmi added a comment.

> This was intended to balance the function updateCalleeCount in InlineFunction.cpp which simply decrements the entry count.

Thanks. After inlining a function, updateCalleeCount and updateCallProfile are used to update entry count of callee and meta data for call instructions. Here what the patch is doing looks like to update the profile when outlining an inline instance, which is the opposite of inlining, so should we update the meta data for call instructions inside the callee as well?


Repository:
  rL LLVM

https://reviews.llvm.org/D52845





More information about the llvm-commits mailing list