[PATCH] D53205: [FPEnv][NFCI] Convert more BinaryOperator::isFNeg(...) to m_FNeg(...)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

I suspect that none of these changes are actually 'NFC'.
Example:
https://reviews.llvm.org/rL344458

I realize it's tedious to come up with these tests, so it's probably ok to say we accept these kinds of changes as general goodness without regression test proof. But we are in the process of enhancing both the IR and backend:
https://reviews.llvm.org/rL343727
https://reviews.llvm.org/rL343940
...to optimize harder based on vector undefs, so any additional test coverage for those cases is much appreciated.



================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:87
+        match(V, m_FNeg(m_Value())) || BinaryOperator::isNot(V))
       return 4;
     return 5;
----------------
cameron.mcinally wrote:
> @spatel, have you given any thought to replacing the integer isNeg (and friends) BinaryOperator helper functions with pattern matcher functions? It will help keep the code more uniform. Just thinking aloud...
Yes, we should get rid of the integer binop helpers as part of the fneg cleanup.


Repository:
  rL LLVM

https://reviews.llvm.org/D53205