[PATCH] D53240: [WebAssembly] WebAssemblyLowerEmscriptenEHSjLj: use getter/setter for accessing tempRet0

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 12 20:41:54 PDT 2018


aheejin added a comment.

- If `__THREW__`, `__threwValue`, and `__tempRet0` are all variables used to communicate between wasm and JS side, isn't it a bit weird that `__tempRet0` is handled differently here?
- Pasted from my comment in emscripten repo <https://github.com/kripken/emscripten/issues/7273#issuecomment-429469606>: They are used to mean different things, and they don't even set the same thing (one sets a global variable in linear memory, and the other sets an wasm global). Should they share the same name in the first place?


Repository:
  rL LLVM

https://reviews.llvm.org/D53240





More information about the llvm-commits mailing list