[PATCH] D35640: [lld] [COFF] Align import address chunks to the pointer size

Yin Ma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 12 16:38:38 PDT 2018


yinma added a comment.
Herald added a reviewer: javed.absar.

Hi, I am hitting an assertion on misalignment. I looked at this logic, Since AArch64 LDR, 31/30 bits are always 1. Size is always 3. Your code is forcing the Imm to be 8 bytes aligned. 
Based on AArch64 specification. Ldr don't have to be 8 bytes aligned. 4 bytes align is very acceptable. I don't understand why LLD forces 8 bytes for COFF on 12L offset? I scanned PECOFF 
document. I didn't see the requirement. Could you let me know why you design in this way? Thanks,


Repository:
  rL LLVM

https://reviews.llvm.org/D35640





More information about the llvm-commits mailing list