[PATCH] D52950: [BPF] Add BTF generation for BPF target

[Yonghong Song via llvm-commits]

On 10/12/18 2:04 PM, Friedman, Eli wrote:
> On 10/12/2018 1:18 PM, Yonghong Song wrote:
>>
>> On 10/12/18 12:48 PM, Eli Friedman via Phabricator wrote:
>>> efriedma reopened this revision.
>>> efriedma added a comment.
>>> This revision is now accepted and ready to land.
>>>
>>> Reverted in r344405.
>>>
>>> Please review the developer policy again before you commit patches in 
>>> the future.  Committing patches without review is not allowed except 
>>> in narrow cases.  And adding new features without tests is not allowed.
>> Sorry for a bunch of failures. Some codes are "borrowed" from linux and
>> I kept the original coding style so we could sync easily but I certainly
>> should have adopted to llvm coding styles.
> 
> Build failures on different compilers is fine... it's often hard to 
> anticipate those issues, and we don't generally expect that all 
> developers will test their patches in every possible environment before 
> merging.  That said, it should have been obvious that including 
> "linux/types.h" will break on non-Linux systems.
> 
>> The patch is actual out for a week before the commit and I did not
>> get any feedback. I will be more active in seeking feedback in
>> the next revision.
> 
> If you feel your patch isn't getting appropriate attention, or you're 
> not sure who to add as a reviewer, please send an email to llvm-dev.

Make sense. I will initiate a discussion once my new revision is ready 
to review. Thanks!

> 
> -Eli
>