[PATCH] D52950: [BPF] Add BTF generation for BPF target

[maskray@google.com via llvm-commits]

On 2018-10-12, Yonghong Song wrote:
>
>
>On 10/12/18 2:03 PM, Fangrui Song via Phabricator wrote:
>> MaskRay added a comment.
>>
>> In https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D52950-231263837&d=DwIFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=YDOkfgXQng3TjI4z7_W3cFlmtJLjN8bziE13VX9lzqI&s=7G9WcWT8eArOKi6GTMiVEYwvzcw_-VS4xte639BIVJI&e=, @efriedma wrote:
>>
>>> Reverted in r344405.
>>>
>>> Please review the developer policy again before you commit patches in the future.  Committing patches without review is not allowed except in narrow cases.  And adding new features without tests is not allowed.
>>
>>
>> Thanks Eli for making it clean. Should the BTF debugging format be discussed on llvm-dev? (I cannot find a thread about it)
>
>I will initiate the thread about this on llvm-dev.
>Thanks.

You should also check if it compiles with MSVC (C99 designated
initializers aren't supported in C++ code; clang support it
[-Wc99-extensions]; gcc supports it) or on other OSes (linux/types.h
will cause trouble)



-- 
宋方睿