[PATCH] D52950: [BPF] Add BTF generation for BPF target

[Rui Ueyama via llvm-commits]

On Fri, Oct 12, 2018 at 1:18 PM Yonghong Song via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
>
> On 10/12/18 12:48 PM, Eli Friedman via Phabricator wrote:
> > efriedma reopened this revision.
> > efriedma added a comment.
> > This revision is now accepted and ready to land.
> >
> > Reverted in r344405.
> >
> > Please review the developer policy again before you commit patches in
> the future.  Committing patches without review is not allowed except in
> narrow cases.  And adding new features without tests is not allowed.
>
> Sorry for a bunch of failures. Some codes are "borrowed" from linux and
> I kept the original coding style so we could sync easily but I certainly
> should have adopted to llvm coding styles.
>

I don't know what exactly you meant by "borrowing" code from Linux, but if
you simply copy code from Linux to LLVM, and if that code is not available
under a compatible license as LLVM's, that will cause trouble. So if you
are doing that, please make it very clear that you know what you are doing.

The patch is actual out for a week before the commit and I did not
> get any feedback. I will be more active in seeking feedback in
> the next revision.
>
> I will add tests and fix all the issues fixed by other kind llvm
> developers for different platforms, compile flags and then resubmit.
>
> Sorry again,
>
> Yonghong
>
> >
> >
> > Repository:
> >    rL LLVM
> >
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D52950&d=DwIFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=TX14v0CKfhFaRRizW8e5GMLE7gfjbfXgDOyF46ZFZqs&s=MavpQT_sJ3xX7qXWE3orv2Nb3O65f7jupkRaH5vIPRk&e=
> >
> >
> >
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181012/0ef52545/attachment.html>