[PATCH] D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 12 09:54:39 PDT 2018


delcypher added a comment.

In https://reviews.llvm.org/D53111#1263563, @eugenis wrote:

> I think this might break android which runs tests at a different absolute path.


Hmm now that I think about it, that's very likely. I don't have an Android device I can test with so I can't really investigate this. How about I add extra condition that checks for `config.android` and if that's true, use the old behaviour (filename rather than an absolute path) along with a `FIXME` comment?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53111





More information about the llvm-commits mailing list