[PATCH] D53162: [DataLayout] Add bit width of pointers to global values

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 12 02:42:38 PDT 2018


bjope added inline comments.


================
Comment at: include/llvm/IR/DataLayout.h:340
+  /// to be 0.
+  unsigned getPointerGlobalBitWidth(unsigned AS = 0) const;
+
----------------
Maybe remove the default here. There are comments about removing AS defaults for other methods here, and usually when someone does not provide the address space in the call it could be a hard to find fault.


Repository:
  rL LLVM

https://reviews.llvm.org/D53162





More information about the llvm-commits mailing list