[compiler-rt] r344324 - Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was set to `False` for macOS.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 19:36:19 PDT 2018


Author: delcypher
Date: Thu Oct 11 19:36:19 2018
New Revision: 344324

URL: http://llvm.org/viewvc/llvm-project?rev=344324&view=rev
Log:
Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was set to `False` for macOS.

`config.asan_dynamic` should actually be `True` because dylibs are the
only supported form of the ASan runtime on Apple platforms.

Reviewers: kubamracek, george.karpenkov, samsonov

Subscribers: srhines, mgorny, #sanitizers, llvm-commits

Differential Revision: https://reviews.llvm.org/D53183

Modified:
    compiler-rt/trunk/test/asan/CMakeLists.txt

Modified: compiler-rt/trunk/test/asan/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/CMakeLists.txt?rev=344324&r1=344323&r2=344324&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/CMakeLists.txt (original)
+++ compiler-rt/trunk/test/asan/CMakeLists.txt Thu Oct 11 19:36:19 2018
@@ -56,7 +56,7 @@ foreach(arch ${ASAN_TEST_ARCH})
   string(TOLOWER "-${arch}-${OS_NAME}" ASAN_TEST_CONFIG_SUFFIX)
   get_bits_for_arch(${arch} ASAN_TEST_BITS)
   get_test_cc_for_arch(${arch} ASAN_TEST_TARGET_CC ASAN_TEST_TARGET_CFLAGS)
-  if(ANDROID)
+  if(ANDROID OR APPLE)
     set(ASAN_TEST_DYNAMIC True)
   else()
     set(ASAN_TEST_DYNAMIC False)




More information about the llvm-commits mailing list