[PATCH] D53002: Create a new symbol file plugin for cross-platform PDB symbolization

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D53002#1262143, @stella.stamenova wrote:

> I took a quick look at the FileCheck issue and it looks like these have been failing since mid-September!
>
> That’s when the change to use filecheck inside the LLDB tests as a function went in: https://reviews.llvm.org/D50751. The change adds a new required input to dotests.py and updates the cmake files to pass it as well as the xcode project, but any of the bots that are calling dotests.py directly now need to pass the new input too.
>
> Vedant, since you made the change, how do you feel about logging a warning instead of hard failing inside dotests.py and then hardfailing any tests that use filecheck when it doesn’t exist? That would limit the failures just to those tests instead of all of the tests on these bots. The bot owners will have to update the scripts as well.


Sounds good, I'll send out a patch. Sorry, I didn't count on there being so many different ways the test harness is invoked.

> Zachary, if you can’t get a local repro of the windows or linux failure with your changes, I can get you the logs from our test runs.
> 
> Thanks,
> -Stella
> 
> From: Zachary Turner <zturner at google.com>
>  Sent: Wednesday, October 10, 2018 8:23 PM
>  To: reviews+https://reviews.llvm.org/D53002+public+9ea58f85247e05d8@reviews.llvm.org
>  Cc: aleksandr.urakov at jetbrains.com; aaron.lee.smith <aaron.lee.smith at gmail.com>; Stella Stamenova <stilis at microsoft.com>; pavel at labath.sk; mosescu at google.com; mgorny at gentoo.org; arphaman at gmail.com; llvm-commits at lists.llvm.org; llvm at inglorion.net
>  Subject: Re: [PATCH] https://reviews.llvm.org/D53002: Create a new symbol file plugin for cross-platform PDB symbolization


Repository:
  rL LLVM

https://reviews.llvm.org/D53002